Review Request 119328: Move MakeFileResolver into DAIM

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119328/#review63287
-----------------------------------------------------------

Ship it!


generally looks good to me - thanks!


languages/plugins/custom-definesandincludes/makefileresolver/tests/test_custommake.cpp
<https://git.reviewboard.kde.org/r/119328/#comment44116>

    use KTempDir instead


- Milian Wolff


On July 18, 2014, 6:41 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119328/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 6:41 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> That way it can be reused by kdev-clang
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppparsejob.cpp 5589a57 
>   languages/cpp/includepathcomputer.h 25b8ff4 
>   languages/cpp/includepathcomputer.cpp f43cb7f 
>   languages/cpp/makefileresolver.h cf75f30 
>   languages/cpp/makefileresolver.cpp 1bb58ef 
>   languages/cpp/tests/CMakeLists.txt 464a6f4 
>   languages/plugins/custom-definesandincludes/CMakeLists.txt becaf36 
>   languages/plugins/custom-definesandincludes/definesandincludesmanager.h b53415f 
>   languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp 29c4c15 
>   languages/plugins/custom-definesandincludes/idefinesandincludesmanager.h a077a33 
>   languages/plugins/custom-definesandincludes/makefileresolver/CMakeLists.txt PRE-CREATION 
>   languages/plugins/custom-definesandincludes/makefileresolver/makefileresolver.h PRE-CREATION 
>   languages/plugins/custom-definesandincludes/makefileresolver/makefileresolver.cpp PRE-CREATION 
>   languages/plugins/custom-definesandincludes/makefileresolver/tests/CMakeLists.txt PRE-CREATION 
>   languages/plugins/custom-definesandincludes/makefileresolver/tests/test_custommake.h PRE-CREATION 
>   languages/plugins/custom-definesandincludes/makefileresolver/tests/test_custommake.cpp PRE-CREATION 
>   languages/cpp/CMakeLists.txt bc72ab6 
>   languages/cpp/codegen/unresolvedincludeassistant.cpp a8d140c 
>   languages/cpp/cpplanguagesupport.cpp 719d227 
> 
> Diff: https://git.reviewboard.kde.org/r/119328/diff/
> 
> 
> Testing
> -------
> 
> Added a simple unit test for it.
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140727/990b2a38/attachment.html>