Review Request 119449: Move compiler related settings to it's own tab & port to QTreeView

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119449/#review63159
-----------------------------------------------------------


Regarding TreeItem/TreeModel: I see where you both got your ideas from: http://qt-project.org/doc/qt-4.8/itemviews-editabletreemodel.html :)

Still, KDevelop::{TreeItem,TreeModel} doesn't have a dependency on kdevplatformdebugger. I agree that the headers look a bit unfortunate with all their FIXMEs and TODOs, but we should try to make it usable for others. Using them would also save you from reimplementing QAIM::removeRows and friends within your custom model from what I can see.

Anyhow, I can understand that's it's easier to just roll your own here -- maybe someone else is in the mood to streamline KDevelop::{TreeItem, TreeModel} at some point. Nevermind.

I think it's fine to commit your code as-is (after fixing the few minor issues I've reported)

- Kevin Funk


On July 25, 2014, 7:26 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119449/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 7:26 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Move compiler related settings to it's own tab & port to QTreeView
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/kcm_widget/compilersmodel.h 7ad7af8 
>   languages/plugins/custom-definesandincludes/kcm_widget/compilersmodel.cpp 51edca0 
>   languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.h 0fad6dc 
>   languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.cpp 3bca90e 
>   languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.ui a21d99c 
>   languages/plugins/custom-definesandincludes/kcm_widget/kcm_customdefinesandincludes.cpp 423da2e 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.h fb3d1eb 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp 60165f8 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui 2817b1b 
> 
> Diff: https://git.reviewboard.kde.org/r/119449/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/07/24/50328bda-b0c2-495a-a8a4-1c8d3ce5fdce__after.png
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/07/24/940635ea-e416-4296-9be1-dfacb07a8796__before.png
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140725/40c8b4a2/attachment.html>