Review Request 119449: Move compiler related settings to it's own tab & port to QTreeView

Sergey Kalinichev kalinichev.so.0 at gmail.com
Fri Jul 25 07:26:26 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119449/
-----------------------------------------------------------

(Updated July 25, 2014, 11:26 a.m.)


Review request for KDevelop.


Changes
-------

Fix couple of bugs. Less magical numbers.


Repository: kdevelop


Description
-------

Move compiler related settings to it's own tab & port to QTreeView


Diffs (updated)
-----

  languages/plugins/custom-definesandincludes/kcm_widget/compilersmodel.h 7ad7af8 
  languages/plugins/custom-definesandincludes/kcm_widget/compilersmodel.cpp 51edca0 
  languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.h 0fad6dc 
  languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.cpp 3bca90e 
  languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.ui a21d99c 
  languages/plugins/custom-definesandincludes/kcm_widget/kcm_customdefinesandincludes.cpp 423da2e 
  languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.h fb3d1eb 
  languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp 60165f8 
  languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui 2817b1b 

Diff: https://git.reviewboard.kde.org/r/119449/diff/


Testing
-------


File Attachments
----------------

after.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/07/24/50328bda-b0c2-495a-a8a4-1c8d3ce5fdce__after.png
before.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/07/24/940635ea-e416-4296-9be1-dfacb07a8796__before.png


Thanks,

Sergey Kalinichev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140725/e651237c/attachment-0001.html>


More information about the KDevelop-devel mailing list