Review Request 119449: Move compiler related settings to it's own tab & port to QTreeView

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119449/#review63099
-----------------------------------------------------------



languages/plugins/custom-definesandincludes/kcm_widget/compilersmodel.h
<https://git.reviewboard.kde.org/r/119449/#comment43845>

    Just "Role", singular.



languages/plugins/custom-definesandincludes/kcm_widget/compilersmodel.h
<https://git.reviewboard.kde.org/r/119449/#comment43848>

    Nitpick: Newline



languages/plugins/custom-definesandincludes/kcm_widget/compilersmodel.h
<https://git.reviewboard.kde.org/r/119449/#comment43847>

    Nitpick: Newline



languages/plugins/custom-definesandincludes/kcm_widget/compilersmodel.h
<https://git.reviewboard.kde.org/r/119449/#comment43846>

    Make that a doxygen comment (///) and attach it to the declaration.



languages/plugins/custom-definesandincludes/kcm_widget/compilersmodel.cpp
<https://git.reviewboard.kde.org/r/119449/#comment43849>

    This looks pretty much like the KDevelop::TreeItem / KDevelop::TreeModel combo. Can you just use this instead?
    
    This would save a lot of duplicated code.


Please make use of KDevelop::TreeItem and KDevelop::TreeModel instead.

In general: The new dialog looks *a lot* better than the old one. Good work! :)

- Kevin Funk


On July 24, 2014, 8:09 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119449/
> -----------------------------------------------------------
> 
> (Updated July 24, 2014, 8:09 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Move compiler related settings to it's own tab & port to QTreeView
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.h 0fad6dc 
>   languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.cpp 3bca90e 
>   languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.ui a21d99c 
>   languages/plugins/custom-definesandincludes/kcm_widget/kcm_customdefinesandincludes.cpp 423da2e 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.h fb3d1eb 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp 60165f8 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui 2817b1b 
>   languages/plugins/custom-definesandincludes/kcm_widget/compilersmodel.cpp 51edca0 
>   languages/plugins/custom-definesandincludes/kcm_widget/compilersmodel.h 7ad7af8 
> 
> Diff: https://git.reviewboard.kde.org/r/119449/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/07/24/50328bda-b0c2-495a-a8a4-1c8d3ce5fdce__after.png
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/07/24/940635ea-e416-4296-9be1-dfacb07a8796__before.png
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140724/7d310e55/attachment.html>