Review Request 119375: Fix include paths for QT5 projects

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119375/#review62872
-----------------------------------------------------------

Ship it!


In general: LGTM, but please consider refactoring the code.


clangparsejob.cpp
<https://git.reviewboard.kde.org/r/119375/#comment43589>

    This code here looks a bit overly complex.
    
    Could you maybe introduce a free function along `ProjectFileItem* findProjectFileItem(IndexedString)`? Then inside the ctor, it gets as easy as `if (auto file = findProjectFileItem(...)) { ... } else { ... }`


- Kevin Funk


On July 20, 2014, 6:41 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119375/
> -----------------------------------------------------------
> 
> (Updated July 20, 2014, 6:41 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 332856
>     https://bugs.kde.org/show_bug.cgi?id=332856
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This patch uses the same technique as the one used in oldcpp.
> 
> 
> Diffs
> -----
> 
>   clangparsejob.cpp 315d1e5 
> 
> Diff: https://git.reviewboard.kde.org/r/119375/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140722/da08c1eb/attachment.html>