Review Request 119214: Respect the "DoNotCloseOnCursorMove" property of navigation widgets

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119214/#review62079
-----------------------------------------------------------

Ship it!


you commit this into 1.7 and this will then merged into master and that in turn into frameworks.

- Milian Wolff


On July 10, 2014, 3:18 p.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119214/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 3:18 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> When the "DoNotCloseOnCursorMove" property of a navigation widget is set, the widget should not be closed when the text cursor moves (if the current document is modified by the widget, for instance).
> 
> This patch fixes a small error in contextbrowser.cpp: the cursorPositionChanged signal was connected to hideToolTip only if the "DoNotCloseOnCursorMove" was not set, but this signal was never disconnected. This made "DoNotCloseOnCursorMove" work as long as the user does not open any widget on which the property is not set (such a widget connected the signal with no chance of having it disconnected later).
> 
> (note: do I commit this patch in master or in frameworks?)
> 
> 
> Diffs
> -----
> 
>   plugins/contextbrowser/contextbrowser.cpp cf03b16 
> 
> Diff: https://git.reviewboard.kde.org/r/119214/diff/
> 
> 
> Testing
> -------
> 
> The helper widgets of QML/JS (for instance, the one that allows to select a color) now work reliably and are not closed when they update the document, even after an extensive editing session during which many navigation widgets have been opened.
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140710/e7a4bb61/attachment.html>