Review Request 119192: Make shell scripts portable and stable

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119192/#review62022
-----------------------------------------------------------


Honestly, I dislike some of the changes and personally I'd rather force to be under /bin/bash instead of doing arcane hacks in order to support /bin/sh.
(Not to mention that I'd rather rewrite that thing in "a proper scripting language")

I'll let Milian have the final say, though.


util/kdevplatform_shell_environment.sh
<https://git.reviewboard.kde.org/r/119192/#comment43154>

    *Shrug*. Ugly but it seems there's no way around that under sh.



util/kdevplatform_shell_environment.sh
<https://git.reviewboard.kde.org/r/119192/#comment43152>

    Do we really need this ugly work-arounds with prefixing with 'X'?
    
    Isn't that really only an issue with ancient shells?


- Kevin Funk


On July 9, 2014, 6:49 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119192/
> -----------------------------------------------------------
> 
> (Updated July 9, 2014, 6:49 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This patch makes provided scripts run on a generic Unix, and not only on bash-enabled ones. Also, some concepts were changed to more correct ones.
> 
> Patches are both applicable to stable and master branches.
> 
> Please note that I do not have commit rights.
> 
> 
> Diffs
> -----
> 
>   util/kdev_format_source 84434b1 
>   util/kdevplatform_shell_environment.sh 216e8c3 
> 
> Diff: https://git.reviewboard.kde.org/r/119192/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140709/6dd21b1c/attachment.html>