Review Request 118818: Detect if 'bzr whoami' informations are available and if not provide default one from KEMailSettings

[Milian Wolff]

> On July 9, 2014, 2:28 p.m., Milian Wolff wrote:
> > this patch is obsolete now that 
> > 
> > commit 24afe1b88610cdc73c44a2dafd1ef4b04c6bf78d
> > Author: Maciej Poleski <d82ks8djf82msd83hf8sc02lqb5gh5 at gmail.com>
> > Date:   Tue Jun 17 23:35:42 2014 +0200
> > 
> >     Fix Bazaar VCS plugin tests (provide Maciej Poleski informations for each test branch)
> > 
> > is in, or?
> 
> Maciej Poleski wrote:
>     Sorry, I don't understand your question. Could You use simpler wording?

Is the patch in this review request here still valid? I.e. do we want to integrate this? I think that now the tests are running (thanks to the commit I pointed out above), it is not required anymore and we can close this review request?


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118818/#review61983
-----------------------------------------------------------


On June 18, 2014, 8:59 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118818/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 8:59 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Detect if 'bzr whoami' informations are available during testing. If not use KEMailSettings to get defaults and set them on per-branch basis.
> 
> 
> Diffs
> -----
> 
>   plugins/bazaar/tests/bazaartest.cpp 86ff36f 
>   plugins/bazaar/tests/bazaartest.h 29248aa 
> 
> Diff: https://git.reviewboard.kde.org/r/118818/diff/
> 
> 
> Testing
> -------
> 
> Tested on environment with and without 'bzr whoami' informations.
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140709/f52a1ff7/attachment.html>