Review Request 119192: Make shell scripts portable and stable

[Vadim Zhukov]

> On Июль 9, 2014, 5:58 п.п., Kevin Funk wrote:
> > How is this supposed to work with /bin/sh?
> > 
> > ./util/kdev_format_source: 44: ./util/kdev_format_source: function: not found
> > 
> > The "function" keyword is a bash-ism, I guess?

Yep, you're right. I've tested this on pdksh which wasn't offended. I've updated a diff.


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119192/#review61978
-----------------------------------------------------------


On Июль 9, 2014, 3:20 п.п., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119192/
> -----------------------------------------------------------
> 
> (Updated Июль 9, 2014, 3:20 п.п.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This patch makes provided scripts run on a generic Unix, and not only on bash-enabled ones. Also, some concepts were changed to more correct ones.
> 
> Patches are both applicable to stable and master branches.
> 
> Please note that I do not have commit rights.
> 
> 
> Diffs
> -----
> 
>   util/kdev_format_source 84434b1 
>   util/kdevplatform_shell_environment.sh 216e8c3 
> 
> Diff: https://git.reviewboard.kde.org/r/119192/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140709/49deb1d2/attachment.html>