Review Request 119157: Add MissingIncludePath assistant.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119157/#review61973
-----------------------------------------------------------

Ship it!


yay, that looks nice. just a few style nitpicks throughout. Please fix them before you commit this!

thanks


duchain/clangdiagnosticevaluator.cpp
<https://git.reviewboard.kde.org/r/119157/#comment43134>

    put brace on newline



duchain/clangdiagnosticevaluator.cpp
<https://git.reviewboard.kde.org/r/119157/#comment43135>

    missing whitespaces before else and {



duchain/missingincludepathproblem.cpp
<https://git.reviewboard.kde.org/r/119157/#comment43136>

    put brace on newline, same for the class and functions below


- Milian Wolff


On July 7, 2014, 1:28 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119157/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 1:28 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This assistant becomes available when clang can't find #include'd file.
> 
> 
> Diffs
> -----
> 
>   duchain/CMakeLists.txt 7cf750f 
>   duchain/clangdiagnosticevaluator.cpp e5009b6 
>   duchain/missingincludepathproblem.h PRE-CREATION 
>   duchain/missingincludepathproblem.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119157/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140709/e72de12f/attachment.html>