Review Request 119184: Fixed compilation error by porting tests from DumpChain to DUChainDumper.

Kevin Funk kfunk at kde.org
Tue Jul 8 18:33:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119184/#review61926
-----------------------------------------------------------

Ship it!


Please create DUChainDumper on the stack. Apart from that: +1

- Kevin Funk


On July 8, 2014, 6:28 p.m., Miquel Sabaté Solà wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119184/
> -----------------------------------------------------------
> 
> (Updated July 8, 2014, 6:28 p.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> The DumpChain class was removed from kdevplatform master in commit a636951a396c9129ac3951828c62d84ccef07108 . I don't know if this is the proper usage of this new class but I guess so :)
> 
> 
> Diffs
> -----
> 
>   duchain/tests/duchaintestbase.cpp 27c96d4 
> 
> Diff: https://git.reviewboard.kde.org/r/119184/diff/
> 
> 
> Testing
> -------
> 
> make test
> 
> 
> Thanks,
> 
> Miquel Sabaté Solà
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140708/36b12605/attachment-0001.html>


More information about the KDevelop-devel mailing list