Review Request 119137: Update the QtHelp plugin so that it works with the latest QMLJS version

[Aleix Pol Gonzalez]

> On July 6, 2014, 10:51 p.m., Aleix Pol Gonzalez wrote:
> > documentation/qthelp/qthelpproviderabstract.cpp, line 75
> > <https://git.reviewboard.kde.org/r/119137/diff/1/?file=287459#file287459line75>
> >
> >     I don't have the QML. prefix in the documentation. Maybe it's something Qt4 vs Qt5?
> 
> Denis Steckelmacher wrote:
>     I've tried without the QML. prefix and it does not work with Qt4. I'll install the Qt5 documentation and I hope that the Qt5 documentation can also be used for Qt4-era QML components. This way, I can simply remove QML. and say that the plugin works only with the Qt5 documentation.
>     
>     Another solution would be to detect which version of the documentation is installed, but it may be a bit too complex for a patch that I try to keep minimal.

You can ship it now, but don't forget to look into the QML. prefix.

FWIW, in the last Qt 4.8 doc snapshots I didn't have QML. in there, AFAIK. What version do you have?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119137/#review61761
-----------------------------------------------------------


On July 7, 2014, 11:31 a.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119137/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 11:31 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This patch slightly simplifies how QML declarations are transformed to QtHelp identifiers and fixes two bugs:
> 
> * Namespace alias declarations have no abstractType(), so the old code that used abstractType() without checking that is wasn't null crashed
> * The current QML/JS plugin puts declarations in namespaces (QtQuick2.0, QtQuick.Controls1.0, etc). These namespaces have to be stripped in order for the identifiers to be found by QtHelp
> 
> 
> Diffs
> -----
> 
>   documentation/qthelp/qthelpproviderabstract.cpp 9ba7ccd 
> 
> Diff: https://git.reviewboard.kde.org/r/119137/diff/
> 
> 
> Testing
> -------
> 
> C++ declarations are still recognized and the QtHelp testsuite passes with this patch applied. Manual testing has shown that QML declarations are properly bound to their documentation. Help for QML properties does not work with this patch, but it did not work either before this patch, with the latest QML/JS plugin.
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140707/c4c65363/attachment.html>