Review Request 119137: Update the QtHelp plugin so that it works with the latest QMLJS version

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119137/#review61761
-----------------------------------------------------------



documentation/qthelp/qthelpproviderabstract.cpp
<https://git.reviewboard.kde.org/r/119137/#comment42988>

    Yes, that was huge hack, thanks. :)



documentation/qthelp/qthelpproviderabstract.cpp
<https://git.reviewboard.kde.org/r/119137/#comment42987>

    better do !idParts.isEmpty()



documentation/qthelp/qthelpproviderabstract.cpp
<https://git.reviewboard.kde.org/r/119137/#comment42986>

    I don't have the QML. prefix in the documentation. Maybe it's something Qt4 vs Qt5?


- Aleix Pol Gonzalez


On July 5, 2014, 7:24 p.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119137/
> -----------------------------------------------------------
> 
> (Updated July 5, 2014, 7:24 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This patch slightly simplifies how QML declarations are transformed to QtHelp identifiers and fixes two bugs:
> 
> * Namespace alias declarations have no abstractType(), so the old code that used abstractType() without checking that is wasn't null crashed
> * The current QML/JS plugin puts declarations in namespaces (QtQuick2.0, QtQuick.Controls1.0, etc). These namespaces have to be stripped in order for the identifiers to be found by QtHelp
> 
> 
> Diffs
> -----
> 
>   documentation/qthelp/qthelpproviderabstract.cpp 9ba7ccd 
> 
> Diff: https://git.reviewboard.kde.org/r/119137/diff/
> 
> 
> Testing
> -------
> 
> C++ declarations are still recognized and the QtHelp testsuite passes with this patch applied. Manual testing has shown that QML declarations are properly bound to their documentation. Help for QML properties does not work with this patch, but it did not work either before this patch, with the latest QML/JS plugin.
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140706/7c2b5191/attachment-0001.html>