Review Request 119140: Add includeBoundary parameter to the contains method in the RangeInRevision

[Sven Brauch]

> On July 6, 2014, 12:29 p.m., Sven Brauch wrote:
> > Can you make it an enum which says e.g. IncludeBackEdge? Then you know what it means when you read the code which calls it.
> 
> Sergey Kalinichev wrote:
>     Of course I can, but why bother? IMO introducing an enum will only pollute the code. Also I've added comments for this function/parameter that explain what is what. 
>     
>     > Then you know what it means when you read the code which calls it
>     
>     Why can't you do it now, e.g. by hovering over the function?

Well, if I read r.contains(q, IncludeBackEdge) I immediately know what it means, whereas for r.contains(q, true) I need to read the docs first. See also e.g. http://qt-project.org/wiki/API-Design-Principles#af0a1b927900205f0daecbcfe3a601c2

But I don't have a very strong opinion on this, if you prefer it with the bool go ahead.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119140/#review61690
-----------------------------------------------------------


On July 6, 2014, 12:22 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119140/
> -----------------------------------------------------------
> 
> (Updated July 6, 2014, 12:22 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This parameter determines whether value at the boundary should be checked too.
> 
> 
> Diffs
> -----
> 
>   language/duchain/duchainutils.cpp 823decf 
>   language/editor/rangeinrevision.h e636c21 
> 
> Diff: https://git.reviewboard.kde.org/r/119140/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140706/ef60f08a/attachment-0001.html>