Review Request 119140: Add containsOrAtTheBoundary method to the RangeInRevision

Sven Brauch svenbrauch at googlemail.com
Sun Jul 6 10:10:57 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119140/#review61681
-----------------------------------------------------------


Maybe adding an optional enum argument to contains() would be cleaner? I think that's how it is done elsewhere.

- Sven Brauch


On July 6, 2014, 7:06 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119140/
> -----------------------------------------------------------
> 
> (Updated July 6, 2014, 7:06 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Add containsOrAtTheBoundary method to the RangeInRevision
> 
> 
> Diffs
> -----
> 
>   language/duchain/duchainutils.cpp 823decf 
>   language/editor/rangeinrevision.h e636c21 
> 
> Diff: https://git.reviewboard.kde.org/r/119140/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140706/97c62530/attachment-0001.html>


More information about the KDevelop-devel mailing list