Review Request 119109: Use CMake generate_export_header() instead of writing them manually

[Alexander Richardson]

> On July 4, 2014, 1:25 p.m., Kevin Funk wrote:
> > Yep. I started porting to generate_export_header once but didn't proceed because of the cyclic dependency issue (mostly caused by KDevelop::IndexedString being used everywhere which is creating a dependency on kdevplatformlanguage for multiple libraries).
> > 
> > If it still compiles. Go for it.
> > 
> > Are you trying to make this compile under Windows? Because porting to generate_export_header has been the biggest blocker in making it work on Windows again.

I have not yet tried this on Windows, but it should be a step in the right direction


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119109/#review61599
-----------------------------------------------------------


On July 4, 2014, 2:07 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119109/
> -----------------------------------------------------------
> 
> (Updated July 4, 2014, 2:07 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This exposes a few cyclic dependecies, compilation can be fixed by using
> a custom target_include_directories() call
> 
> 
> Diffs
> -----
> 
>   interfaces/CMakeLists.txt f5c3a07856e9fd74382a57eb149774c439bba627 
>   interfaces/interfacesexport.h e06b18fb43c42a2e1ec7340643339c5475d54e39 
>   interfaces/iproject.h 52ac27f6deb5defdb3c610e20280491a6264b01f 
>   interfaces/tests/CMakeLists.txt 1cbdf6c825616176ebbc8c349bdfe760f9a97094 
>   language/CMakeLists.txt 8acec0b645b18f82d8360e4ad17167c85fe7e068 
>   language/assistant/renamefileaction.cpp 2090a5ca86b0fa493d3080b2c35b4309ea8db516 
>   language/codegen/documentchangeset.cpp 4b46986a5bf266f7c66365e76b2b90de44be98a8 
>   plugins/documentview/CMakeLists.txt f02517be386f42e4bc1868321ad1acf3b6d10f25 
>   plugins/genericprojectmanager/CMakeLists.txt 96e2a65c4b6a256c2fa2479699d4744ceae202a4 
>   plugins/git/stashmanagerdialog.cpp 542e609dc58da7436a23a34672ffb29f981b9929 
>   plugins/projectmanagerview/projectmanagerview.cpp 94b19b711bc094cc0fb6b560e37df76b94330113 
>   plugins/reviewboard/CMakeLists.txt 5990c6662e4f4f63d256c3db66dc9ccb916d9199 
>   project/CMakeLists.txt d7790eda47483fa2bf253a70c4c5d2f4d7a3d51e 
>   project/interfaces/ibuildsystemmanager.h 241b6965460b5aed1ccc5ca52c0c66567ba45945 
>   project/interfaces/iprojectbuilder.h b9c0527d22ec62e8148463dd8e0149b4c9578c70 
>   project/interfaces/iprojectfilemanager.h 76c812ae5c8d9c795953eee1983f3dbde896590d 
>   project/interfaces/iprojectfilter.h e133c22265453e66454afdccd588370238803627 
>   project/interfaces/iprojectfilterprovider.h 431a63367dc32a2346eb12cd5a26955eb467b1c8 
>   project/projectexport.h d509c8944ccc043f02a03288a7fb6c3d301c05f4 
>   project/projectmodel.h 74402a7880a8ac0e6d8a2dd4e60bd858d848e939 
>   shell/CMakeLists.txt 2eb64278b3c10b6142ac51212b19d2cf7fbc2a11 
>   shell/project.h a798ef03477015966229456ade7620cd534ec724 
>   shell/settings/environmentpreferences.cpp c17d1fdf149877f36a6219dfddde4cfdff8093b2 
>   shell/shellexport.h f057b1479b3dab21887e421cdaf6a40bf1e4a8f0 
>   sublime/CMakeLists.txt 757af87be7e1c5ea9d354f4d9e064eba52e273bc 
>   tests/CMakeLists.txt 641f1c789c76bc003c7e1590d43ea88048aee282 
>   tests/json/CMakeLists.txt 12ee68352aecf740b6135bd823ab57c3b2aeaef4 
>   tests/json/kdevplatformjsontestsexport.h 7ed27f8045eb710eae8192f532064387144d40fe 
>   tests/kdevplatformtestsexport.h 8c7539f8aaee771b400316461e5a185b8738cede 
>   util/CMakeLists.txt bd0f591d2a5ee0ff71c82961e81547cb28ad5a00 
>   util/utilexport.h 223c15c4e621ac6093ba800dd1735ce155865020 
>   vcs/models/vcsitemeventmodel.cpp d836f0a3b0fa5a849fa152d069d6fce164f8d3ec 
> 
> Diff: https://git.reviewboard.kde.org/r/119109/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140704/fc45ebee/attachment.html>