Review Request 119108: Replace KSharedPtr with QExplicitlySharedDataPointer

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119108/#review61579
-----------------------------------------------------------

Ship it!


awesome, I only skimmed through the diff but it sounds like a good thing to have!

thanks

- Milian Wolff


On July 3, 2014, 9:48 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119108/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 9:48 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Replace KSharedPtr with QExplicitlySharedDataPointer
> 
> 
> Diffs
> -----
> 
>   documentation/documentationview.h e0fa7d6f1417e0870b90fc757c1092b103a2c80c 
>   documentation/documentationview.cpp f0195c4d47998412a5e215bcc7b2fb4030050952 
>   interfaces/iassistant.h ab2730089b0ab76c58d2a96e97880a71b3ca7f99 
>   interfaces/iassistant.cpp 428f12a703422fa4baad6567caef78d5acd8d1f9 
>   interfaces/idocumentation.h 6530337ff5cb891cde417fba9539ac5fa909a8b3 
>   interfaces/idocumentationcontroller.h c9edf6940c8c84626ba2aa3de2b47cea7a0b7733 
>   interfaces/idocumentationprovider.h 0c973e85146cb8593c26394ebc135ed6cd54a908 
>   interfaces/idocumentationproviderprovider.h eb22abc6726f6622bd7712a861c20cbd2e5e1c1d 
>   interfaces/iuicontroller.h 5f4951caaa33959d5965c346d664ab20a5c11309 
>   language/assistant/renameassistant.cpp 289e2ef4357e4dfce68531b0f9e67d763d15a468 
>   language/assistant/staticassistant.h a97f197e31198964b58bcc5efa8fb6fecea3b9de 
>   language/assistant/staticassistantsmanager.h 968dc98d363f5948cd3ee6f63f3a6e0185164f19 
>   language/assistant/staticassistantsmanager.cpp 0aeec4744c1da9457610d295c9003b0fd48ff95e 
>   language/backgroundparser/documentchangetracker.h 987d86aab0698daeb05f2aa972df88b3d07e4b7e 
>   language/codecompletion/codecompletioncontext.h 6ea9e4f28e1eb84cde2b38e2aed5414218bea550 
>   language/codecompletion/codecompletioncontext.cpp 43ad50650b7824bbd47065d2ddc3e9e0c3d00e62 
>   language/codecompletion/codecompletionitem.h ac89e8dc5b0087bfcaade01823b9d0f41f43a52f 
>   language/codecompletion/codecompletionitem.cpp 4051237d9280c8838d2a76cfed3b7c031379d371 
>   language/codecompletion/codecompletionitemgrouper.h 6c7593e21b1dd458ca41b7ba90518fa6474ef58d 
>   language/codecompletion/codecompletionmodel.h 4161fe10e11febcc46e5dc79058af756bcce00f9 
>   language/codecompletion/codecompletionmodel.cpp 7c400a1f77f8879f9173f3c5ea69018cb7e67255 
>   language/codecompletion/codecompletiontesthelper.h e37dd152203f8db52519f414001af86b56d8ec6a 
>   language/codecompletion/codecompletionworker.h 259b7f3c72928c24a30bff04cbba262b84b7a482 
>   language/codecompletion/codecompletionworker.cpp bef95ab58ef3ec8295ef1e50efc435a0ccabfce1 
>   language/codecompletion/normaldeclarationcompletionitem.h 94815356bfabdf43c96e24577ff390be2dd96621 
>   language/codecompletion/normaldeclarationcompletionitem.cpp 7a9573f9b20323f5120b4ff25b89323b3c89547c 
>   language/codegen/coderepresentation.h a866ee31e93700db3daeb53aa18125e8b77cd5c7 
>   language/codegen/coderepresentation.cpp 2be1366526de674932ba7cae6d45949c8a5ea4dd 
>   language/codegen/documentchangeset.h e0d06c4e4d9df5a58f368649da6444f0fc4fa8c8 
>   language/duchain/duchain.h dd84bf7281f9b77f38fbd7cf1c652158b13839f2 
>   language/duchain/duchain.cpp 35a1a2e9e5c57af1ccfefa4da69a50e64f277453 
>   language/duchain/duchainbase.h 0c116372e820d9bd287ddfc2c03f79adc338148f 
>   language/duchain/duchainbase.cpp 0c8d438557ad16f5eec5b8843f378b9bb8718c99 
>   language/duchain/duchainpointer.h 0bbde8c9f8ca7ce5c5bde0fe73f149be5e3557ab 
>   language/duchain/ducontext.h 337c40e95e072beb71bd9f60adba16db970beeda 
>   language/duchain/navigation/abstractdeclarationnavigationcontext.cpp 1c8672fcce547f8de0057fac6bf732ebfe1c0b22 
>   language/duchain/navigation/abstractnavigationcontext.h 32fe675af7943ef54dbd9ab1369e2aa15a07082f 
>   language/duchain/navigation/abstractnavigationcontext.cpp 945e6399959a41099db7b4d73610f2bd004dcd2f 
>   language/duchain/navigation/problemnavigationcontext.cpp 246a96c41e608489849ddc7b43c1812a3637b737 
>   language/duchain/parsingenvironment.h 03f39f89212b7cbddfada93d69a54d0b4fc488d3 
>   language/duchain/parsingenvironment.cpp 8789c5486fda170bd8925973865d79c8305601c5 
>   language/duchain/problem.h 41acc79b5c0b93a916f21d6b51074d53a97ea14e 
>   language/duchain/problem.cpp dd36643844c45c1a003847403c8b644fd63bd2c9 
>   language/duchain/topducontext.h 8ad013080aba10646332a2857706ae2cde5951b9 
>   language/duchain/topducontext.cpp e5407e3acb4b006bcf15d25c818748196929d16f 
>   language/duchain/topducontextdynamicdata.cpp 8a0973191987b939260d70fdc01fe8d5fe3d8b5f 
>   language/editor/persistentmovingrange.h a3fcca6dc406f1b9f4d464723db069a45939f84a 
>   language/interfaces/iastcontainer.h bd0c83a9559212f3933f57f4f01c7d2eb7ecbfb9 
>   language/interfaces/quickopendataprovider.h fa03a8dcd6052ecdcf84c1ea5988d5ccbed74ffe 
>   plugins/problemreporter/problemwidget.cpp cb70ea234b58a46578e7ad3de9eb567d610ea4d8 
>   shell/assistantpopup.h 156a2c1de8ccd0ffc2de72da657b34db62ef5fd5 
>   shell/documentationcontroller.h 4aa74bb5048da9ce9db9fa1b5f1a5dc1441f7a02 
>   shell/documentationcontroller.cpp 45c40565e9f31c62793f912c10e8f19beb0cb209 
>   shell/sourceformattercontroller.cpp adca960d65580a0eb13971313706a628f349cf2d 
>   util/ksharedobject.h 7faf4573285f9eeff60a50bcc225b2711a17e147 
> 
> Diff: https://git.reviewboard.kde.org/r/119108/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140703/fdfa3cf2/attachment-0001.html>