Review Request 115383: Reuse code in Refactor widget. Changes in kdevplatform

[Sergey Kalinichev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115383/
-----------------------------------------------------------

(Updated Jan. 31, 2014, 12:41 p.m.)


Review request for KDevelop.


Changes
-------

Holding the lock while calling newNameForDeclaration will prevent UsesCollector from collecting items. So I've decided to pass around a DeclarationPointer.


Repository: kdevplatform


Description
-------

Refactore code out a little bit so that language plugins can reuse even more code if they want to reimplement startInteractiveRename function.


Diffs (updated)
-----

  language/duchain/navigation/useswidget.cpp 2fd0bd9 
  language/duchain/navigation/useswidget.h f52d868 
  language/codegen/basicrefactoring.cpp d5e8c67 
  language/codegen/basicrefactoring.h 06606a5 

Diff: https://git.reviewboard.kde.org/r/115383/diff/


Testing
-------


Thanks,

Sergey Kalinichev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140131/bad42e72/attachment.html>