Review Request 115384: Reuse code in Refactor widget. Changes in kdevelop

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115384/#review48633
-----------------------------------------------------------

Ship it!


Looks good to me!

And yes, the big amount of changes is confusing. As I said - next time do a cleanup commit first, then in a separate review request add the functional changes ontop. That simplifies the review process.

Thanks!

- Milian Wolff


On Jan. 30, 2014, 8:46 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115384/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 8:46 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Reuse new functions implemented in BasicRefactoring class. Also clean up code a little bit.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codegen/simplerefactoring.cpp ad318d1 
> 
> Diff: https://git.reviewboard.kde.org/r/115384/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140130/49f5dd47/attachment.html>