Review Request 115399: kdev-clang: Introduce "Best matches" completion group.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115399/#review48632
-----------------------------------------------------------

Ship it!


Awesome work! Two small nitpicks, then I'm all for it.

PS: You should register for a KDE account for commit access. I'll vouch for you.


codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/115399/#comment34348>

    rename to MAX_PRIORITY_FOR_BEST_MATCHES to reflect that its an upper limit



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/115399/#comment34349>

    rewrite this as:
    
    auto item = CompletionTreeItemPointer(new ...);
    if (... < ...) {
        bestMatches << item;
    } else {
        items << item;
    }
    


- Milian Wolff


On Jan. 30, 2014, 1:37 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115399/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 1:37 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Sort code completion results with highest priority to the "Best matches" group so that they'll appear at the top of completion list. 
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp 171ca8a 
> 
> Diff: https://git.reviewboard.kde.org/r/115399/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/4373845c-5f24-475a-b6db-78262720a6d8__before.png
> after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/9188ca50-e13d-4071-934b-8318ee30ce03__after.png
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140130/fb065dfa/attachment.html>