Review Request 115384: Reuse code in Refactor widget. Changes in kdevelop

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115384/#review48560
-----------------------------------------------------------


also seems to look good here - thanks for that!


languages/cpp/codegen/simplerefactoring.cpp
<https://git.reviewboard.kde.org/r/115384/#comment34323>

    please scope the lock instead of lock/unlocking it manually 


- Milian Wolff


On Jan. 29, 2014, 4:07 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115384/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 4:07 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Reuse new functions implemented in BasicRefactoring class. Also clean up code a little bit.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codegen/simplerefactoring.cpp ad318d1 
> 
> Diff: https://git.reviewboard.kde.org/r/115384/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140129/3ff36311/attachment.html>