Review Request 115374: Port the BasicRefactoring::startInteractiveRename code to a .ui

[Sven Brauch]

> On Jan. 29, 2014, 10:23 a.m., Sergey Kalinichev wrote:
> > Hmm, I've just noticed that cpp language plugin creates _exactly_ the same rename widget manually over again... Maybe we could introduce some function like createBasicRenameWidget in kdevplatform which will create a rename widget and produce simple input validation or something like that?
> > Or maybe it'll be more simple to port simplerefactoring.cpp to the same ui too?
> >

Yes, that this thing exists in kdevplatform in the first place is the first step towards solving that problem (which was taken only a few days ago). C++ support should now just instantiate the class from kdevplatform. You're very welcome to do this change. There shouldn't be a function, however, C++ should just instantiate the class itself; that way, it can easily do changes to the widget by inheriting from it.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115374/#review48519
-----------------------------------------------------------


On Jan. 29, 2014, 9:07 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115374/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 9:07 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 330263
>     http://bugs.kde.org/show_bug.cgi?id=330263
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> There is one open question though: Should there be foolproof checks or not? (e.g. new name doesn't contain spaces, dots, braces e.t.c).
> I think there should be input validation, still maybe that check isn't implemented intentionally so that all other languages, that consider those symbols valid for function/variable names, can use refactoring capabilities too?
> 
> 
> Diffs
> -----
> 
>   language/CMakeLists.txt 11a26da 
>   language/codegen/basicrefactoring.cpp 3c584d2 
>   language/codegen/basicrefactoring.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115374/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140129/cd72062e/attachment.html>