Review Request 115356: option to automatically format Python code to PEP8 with AutoPEP8

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115356/#review48482
-----------------------------------------------------------


besides the problems outlined below, this should instead become a source formatter for python mimetype(s). Then it can be configured properly (if required/possible) via settings -> indentation and the existing "format source(s)" actions can be reused.


pep8kcm/kcm_pep8.cpp
<https://git.reviewboard.kde.org/r/115356/#comment34283>

    this should use KStandardDirs::findExe see http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKStandardDirs.html#a2cdee9ed57939256abd672bb4c6cb5cf



pythonlanguagesupport.cpp
<https://git.reviewboard.kde.org/r/115356/#comment34284>

    same as below - put it into a separate function to share code and keep the default in sync


- Milian Wolff


On Jan. 28, 2014, 3:07 p.m., Ashwin Rajeev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115356/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 3:07 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> automatically formats Python code to PEP8 with AutoPEP8
> 
> 
> Diffs
> -----
> 
>   pep8kcm/kcm_pep8.h e837d10 
>   pep8kcm/kcm_pep8.cpp 71a23a3 
>   pythonlanguagesupport.h 0a93d07 
>   pythonlanguagesupport.cpp 9ad723c 
> 
> Diff: https://git.reviewboard.kde.org/r/115356/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashwin Rajeev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140128/d4213109/attachment.html>