Review Request 115331: Make kdev-clang compile with llvm-3.4

[Kevin Funk]

> On Jan. 27, 2014, 6:54 p.m., Kevin Funk wrote:
> > Just discussed a bit with Aleix: While the patch isn't perfect, let's just commit this.
> > 
> > I'll try to come up with a better solution in the meantime.
> 
> Sergey Kalinichev wrote:
>     Oops, I should have mentioned before that on my machine there is only one executable without version in it's name: llvm-clang. All other end with 3.4 (e.g. llvm-nm-3.4).
>     Here is llvm-clang --version output:
>     "clang version 3.4-1 (tags/RELEASE_34/final) (based on LLVM 3.4)
>     Target: llvm
>     Thread model: posix"
>     
>     So, I've updated the patch, see if it fits you.
>     
>     P.S: I'm really sorry for not providing all necessary information in time :(
>

@Sergey: For the record, what distribution is that?

I'll have to come up with a better solution than what we have now. Unfortunately I don't really want to hardcode the find process on 'llvm-clang' either, because that binary doesn't really need to be installed in order to build kdev-clang. Plus, on the next distro that crops up, only 'llvm-clang-3.4' may exist and I have to come up with another solution yet again. 

No problem regarding the missing information, though, we can't think of everything.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115331/#review48408
-----------------------------------------------------------


On Jan. 27, 2014, 9:07 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115331/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 9:07 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Currently FindLLVM.cmake looking for llvm-config-3.3 and llvm-config only. But on my machine there is only llvm-config-3.4. 
> To bypass it let's try to find llvm-clang instead, then retrieve it's directory and try to find llvm-config-* in it.
> 
> NOTE: I'm not very good at cmake, so it'll be nice if someone more experienced could tell if there is a more simple/correct way to achieve it.
> 
> 
> Diffs
> -----
> 
>   cmake/FindLLVM.cmake b77528f 
> 
> Diff: https://git.reviewboard.kde.org/r/115331/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140128/894a0c62/attachment.html>