Review Request 115342: Patch for bug 328307 - No horizontal scrolling possible in grepview

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115342/#review48416
-----------------------------------------------------------


Somehow the patch doesn't fully apply. Can you check?


plugins/grepview/grepoutputview.cpp
<https://git.reviewboard.kde.org/r/115342/#comment34233>

    Nitpicks: Space after keyword, use more appropriate variable name (e.g. 'col')


- Kevin Funk


On Jan. 27, 2014, 8:27 p.m., David Stevens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115342/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 8:27 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 328307
>     http://bugs.kde.org/show_bug.cgi?id=328307
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Fixes the issue with horizontal scrolling described in the bug report. Also fixes a known issue with text width calculation which becomes very obvious with horizontal scrolling.
> 
> 
> Diffs
> -----
> 
>   plugins/grepview/grepoutputdelegate.cpp 1d75efa 
>   plugins/grepview/grepoutputview.cpp bc41dd1 
> 
> Diff: https://git.reviewboard.kde.org/r/115342/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Stevens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140127/ae2538cc/attachment.html>