Review Request 115331: Make kdev-clang compile with llvm-3.4

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115331/#review48395
-----------------------------------------------------------



cmake/FindLLVM.cmake
<https://git.reviewboard.kde.org/r/115331/#comment34221>

    This won't work properly in certain environments, since find_program() sets LLVM_CONFIG_EXECUTABLE in the cache, which has weird connotations.
    
    What I've seen some finders (for example, the Boost, at least some time ago) was to provide a list of the versions and filter it with "VERSION_GREATER".
    
    Another thing you can do, is to get the currently installed version from any other llvm binary (e.g. llvm-nm --version) and then use it instead of LLVM_FIND_VERSION.


- Aleix Pol Gonzalez


On Jan. 27, 2014, 4:13 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115331/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 4:13 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Currently FindLLVM.cmake looking for llvm-config-3.3 and llvm-config only. But on my machine there is only llvm-config-3.4. 
> To bypass it let's try to find llvm-clang instead, then retrieve it's directory and try to find llvm-config-* in it.
> 
> NOTE: I'm not very good at cmake, so it'll be nice if someone more experienced could tell if there is a more simple/correct way to achieve it.
> 
> 
> Diffs
> -----
> 
>   cmake/FindLLVM.cmake b77528f 
> 
> Diff: https://git.reviewboard.kde.org/r/115331/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140127/f9c47170/attachment.html>