Review Request 115327: Fix git->branches... on the root folder.

Milian Wolff mail at milianw.de
Mon Jan 27 11:48:13 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115327/#review48368
-----------------------------------------------------------



vcs/dvcs/dvcsplugin.cpp
<https://git.reviewboard.kde.org/r/115327/#comment34197>

    potentially more safe is to always return an absolute path, so:
    
    return info.isDir() ? path.absoluteFilePath() : info.absolutePath()


- Milian Wolff


On Jan. 27, 2014, 11:42 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115327/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 11:42 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Now pressing git->branches... on the root folder of a project under git will show all available branches instead of showing an error message: Not a git repository...
> 
> 
> Diffs
> -----
> 
>   vcs/dvcs/dvcsplugin.cpp 3e548a3 
> 
> Diff: https://git.reviewboard.kde.org/r/115327/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140127/62b111ee/attachment.html>


More information about the KDevelop-devel mailing list