Review Request 115095: Add initial support for CMake APPEND_STRING.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115095/#review48275
-----------------------------------------------------------


Can you make m_append an enum that differentiates between APPEND and APPEND_STRING?

Thanks for the patch and sorry for the delay!!

- Aleix Pol Gonzalez


On Jan. 17, 2014, 11:55 p.m., Ben Wagner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115095/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 11:55 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> With CMake 2.8.6 there was added an APPEND_STRING option to set_property. In CMake, APPEND appends a ';' to the existing value (when it exists and is non-empty). APPEND_STRING does not append this ';'. This was a simple change in CMake, but adds another odd corner case to KDevelop.
> 
> The parser in CMake will simply hold all appends as a string, and parse that string to a list as needed. In KDevelop the value is always held as a list, so the odd case (which is possible in CMake) where an individual list value is created over multiple commands is not easily emulated in the KDevelop parser.
> 
> Seeing as full support is a rather large change, this change simply makes APPEND_STRING an alias for APPEND in KDevelop which handles almost all cases.
> 
> This will probably need a test, and this may or may not be the best way to do this, but it seems better than failing to parse the set_properties command at all.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/parser/cmakeast.cpp aac1070 
> 
> Diff: https://git.reviewboard.kde.org/r/115095/diff/
> 
> 
> Testing
> -------
> 
> Built. Seems to work ok. Probably needs a real test.
> 
> 
> Thanks,
> 
> Ben Wagner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140125/434e3052/attachment.html>