Review Request 115304: Support syntax for class member access on instantiation in kdev-php

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115304/#review48252
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Jan. 24, 2014, 10:47 p.m., Heinz Wiesinger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115304/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 10:47 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 297908 and 305779
>     http://bugs.kde.org/show_bug.cgi?id=297908
>     http://bugs.kde.org/show_bug.cgi?id=305779
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> Support the syntax for class member access on instantiation.
> 
> This adds support for syntax like (new Foo())->bar() as introduced in PHP 5.4.
> 
> The bug that ($a)-> still offers completion even though it is invalid syntax (stupid PHP) remains though.
> 
> 
> Diffs
> -----
> 
>   duchain/builders/declarationbuilder.cpp 0d45d86e1d992cf0d5aeea7264797c5d91e59f5f 
>   duchain/expressionvisitor.cpp 3bc956f19640afe87ec5ffb2b9d634bed25faba3 
>   duchain/tests/expressionparser.h 0e59aab68c2d8a9c9b8cee84d237f921c29a5c9f 
>   duchain/tests/expressionparser.cpp cb0045ca733cd3b382aeddf574520307a2144e80 
>   parser/php.g 9271989f5ea83dd5974ad5962b75b974edd0212a 
> 
> Diff: https://git.reviewboard.kde.org/r/115304/diff/
> 
> 
> Testing
> -------
> 
> Unit test, Parsing local test files.
> 
> 
> Thanks,
> 
> Heinz Wiesinger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140124/8115ac61/attachment.html>