Review Request 115280: Add Trait alias declaration classes to kdev-php

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115280/#review48250
-----------------------------------------------------------

Ship it!



duchain/declarations/traitmemberaliasdeclaration.cpp
<https://git.reviewboard.kde.org/r/115280/#comment34148>

    i18n from <KLocalizedString> to have it translatable



duchain/declarations/traitmethodaliasdeclaration.cpp
<https://git.reviewboard.kde.org/r/115280/#comment34150>

    const& the vector



duchain/declarations/traitmethodaliasdeclaration.cpp
<https://git.reviewboard.kde.org/r/115280/#comment34149>

    const& the id here


- Milian Wolff


On Jan. 24, 2014, 12:50 a.m., Heinz Wiesinger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115280/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 12:50 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> Add Trait alias declaration classes.
> 
> These help when dealing with trait uses, which are special in the case that they are aliases which allow overriding both name and visibility (rather than just name like the AliasDeclaration).
> Additionally it makes it easier to show specific information in Pop-up tooltips, like what the original name of an aliased method is and where that was originally declared.
> 
> I picked identities that sounded appropriate according to http://techbase.kde.org/Projects/KDevelop4/DUChainIdentities
> 
> 
> Diffs
> -----
> 
>   duchain/declarations/traitmethodaliasdeclaration.cpp PRE-CREATION 
>   duchain/declarations/traitmethodaliasdeclaration.h PRE-CREATION 
>   duchain/declarations/traitmemberaliasdeclaration.cpp PRE-CREATION 
>   duchain/CMakeLists.txt 376edbd861bc331be3fe70435843366d425689c6 
>   duchain/declarations/traitmemberaliasdeclaration.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115280/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Heinz Wiesinger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140124/5174b09c/attachment-0001.html>