Review Request 115196: New declarative based assistant

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115196/
-----------------------------------------------------------

(Updated Jan. 24, 2014, 1:48 p.m.)


Review request for KDevelop.


Changes
-------

Add comments to the QML files.

I tested the shortcut keys with Ctrl+Alt+Down (duplicate line), and it still works. I would also expect it to, because when the widget doesn'T know what to do with a keypress it ignores the event, which should forward it to the parent -- which is the text editor widget.


Repository: kdevplatform


Description
-------

A new proposal for what the assistant should look like. See screenshots.
Ideas welcome :)


Diffs (updated)
-----

  shell/AssistantButton.qml PRE-CREATION 
  shell/CMakeLists.txt f840acd 
  shell/assistantpopup.h 33a462a 
  shell/assistantpopup.cpp c19a149 
  shell/assistantpopup.qml PRE-CREATION 
  shell/uicontroller.cpp fbce314 
  util/CMakeLists.txt cf2fc1a 
  util/richtexttoolbutton.h 8d0b1e2 
  util/richtexttoolbutton.cpp d4263a6 

Diff: https://git.reviewboard.kde.org/r/115196/diff/


Testing
-------


File Attachments
----------------

new assistant, bright colour scheme
  https://git.reviewboard.kde.org/media/uploaded/files/2014/01/21/96c23c0e-106e-47e0-8f80-90303029e521__assistant_bright.png
dark colour scheme
  https://git.reviewboard.kde.org/media/uploaded/files/2014/01/21/d52643d2-3e0d-494b-bdd7-7beac3f4656c__assistant_dark.png
alt pressed
  https://git.reviewboard.kde.org/media/uploaded/files/2014/01/21/1df94b0b-d763-4aef-9182-ab113fcc3b1a__assistant_hl.png
assistant, after triggering an action
  https://git.reviewboard.kde.org/media/uploaded/files/2014/01/21/c118a296-778c-4cff-86a9-1ff63c2a3e48__assistant_trig.png
version 2,  bright
  https://git.reviewboard.kde.org/media/uploaded/files/2014/01/22/80396242-9477-47d0-9b80-238f104ac248__assistant_bright2.png
version 2, dark
  https://git.reviewboard.kde.org/media/uploaded/files/2014/01/22/8c531d60-c6ab-45e5-a05c-6639f4ed8225__assistant_dark.png


Thanks,

Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140124/2e43b222/attachment.html>