Review Request 115196: New declarative based assistant

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115196/#review48149
-----------------------------------------------------------


instead of setting context properties or invoking methods on the root object, please create a QObject class with the required properties, signals etc. pp. and publish that to the QML context


shell/assistantpopup.h
<https://git.reviewboard.kde.org/r/115196/#comment34050>

    braces on newline, also for functions below



shell/assistantpopup.cpp
<https://git.reviewboard.kde.org/r/115196/#comment34051>

    good usecase for auto here
    
    also, below you cast the parent to the view (statically even!) so use that here as well - no?
    
    and please use a dnyamic cast + assert



shell/assistantpopup.cpp
<https://git.reviewboard.kde.org/r/115196/#comment34053>

    please document this more - its quite hacky and shaky after all



shell/assistantpopup.cpp
<https://git.reviewboard.kde.org/r/115196/#comment34052>

    make it a free function - really no need for a lambda here



shell/assistantpopup.cpp
<https://git.reviewboard.kde.org/r/115196/#comment34054>

    move this into the existing eventFilter method



shell/assistantpopup.cpp
<https://git.reviewboard.kde.org/r/115196/#comment34056>

    documentation! this is about the hover effect when pressing alt, right?



shell/assistantpopup.cpp
<https://git.reviewboard.kde.org/r/115196/#comment34057>

    this should only trigger when the modifiers _equal_ the alt modifier - you don't want to show this when one presses alt + shift or such as then the actions won't trigger when you press 1 or so



shell/assistantpopup.cpp
<https://git.reviewboard.kde.org/r/115196/#comment34058>

    store the view in a member variable in the ctor and use it here


- Milian Wolff


On Jan. 23, 2014, 1:46 a.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115196/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 1:46 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> A new proposal for what the assistant should look like. See screenshots.
> Ideas welcome :)
> 
> 
> Diffs
> -----
> 
>   shell/AssistantButton.qml PRE-CREATION 
>   shell/CMakeLists.txt f840acd 
>   shell/assistantpopup.h 33a462a 
>   shell/assistantpopup.cpp c19a149 
>   shell/assistantpopup.qml PRE-CREATION 
>   shell/uicontroller.cpp fbce314 
>   util/CMakeLists.txt cf2fc1a 
>   util/richtexttoolbutton.h 8d0b1e2 
>   util/richtexttoolbutton.cpp d4263a6 
> 
> Diff: https://git.reviewboard.kde.org/r/115196/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> new assistant, bright colour scheme
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/21/96c23c0e-106e-47e0-8f80-90303029e521__assistant_bright.png
> dark colour scheme
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/21/d52643d2-3e0d-494b-bdd7-7beac3f4656c__assistant_dark.png
> alt pressed
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/21/1df94b0b-d763-4aef-9182-ab113fcc3b1a__assistant_hl.png
> assistant, after triggering an action
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/21/c118a296-778c-4cff-86a9-1ff63c2a3e48__assistant_trig.png
> version 2,  bright
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/22/80396242-9477-47d0-9b80-238f104ac248__assistant_bright2.png
> version 2, dark
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/22/8c531d60-c6ab-45e5-a05c-6639f4ed8225__assistant_dark.png
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140123/13d39880/attachment-0001.html>