Review Request 115204: Simplified the SimpleRefactoring class.

Milian Wolff mail at milianw.de
Tue Jan 21 23:10:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115204/#review47952
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Jan. 21, 2014, 10:48 p.m., Miquel Sabaté Solà wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115204/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 10:48 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> We can simplify the SimpleRefactoring class by subclassing it to BasicRefactoring from kdevplaform.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codegen/simplerefactoring.h 9ee5d5a 
>   languages/cpp/codegen/simplerefactoring.cpp 3e88b09 
>   languages/cpp/cpplanguagesupport.h 4c4c8be 
>   languages/cpp/cpplanguagesupport.cpp 30cad77 
>   languages/cpp/tests/test_cppcodegen.cpp 07b8ec0 
> 
> Diff: https://git.reviewboard.kde.org/r/115204/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Miquel Sabaté Solà
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140121/e209169e/attachment-0001.html>


More information about the KDevelop-devel mailing list