Review Request 115196: New declarative based assistant

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115196/#review47931
-----------------------------------------------------------


still a lot of issues as discussed with you - here some code remarks


shell/assistantpopup.cpp
<https://git.reviewboard.kde.org/r/115196/#comment33946>

    move these two lines below the default colors



shell/assistantpopup.cpp
<https://git.reviewboard.kde.org/r/115196/#comment33945>

    remove previous newline



shell/assistantpopup.cpp
<https://git.reviewboard.kde.org/r/115196/#comment33944>

    modifiers


- Milian Wolff


On Jan. 21, 2014, 8:26 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115196/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 8:26 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> A new proposal for what the assistant should look like. See screenshots.
> Ideas welcome :)
> 
> 
> Diffs
> -----
> 
>   shell/AssistantButton.qml PRE-CREATION 
>   shell/CMakeLists.txt f840acd08653d088cc597b098566f2a379f69968 
>   shell/assistantpopup.h 33a462aaa0186a524b0b04dcd3fc920a71219695 
>   shell/assistantpopup.cpp c19a14982b0602882a5eed380c4c7aad6669c756 
>   shell/assistantpopup.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115196/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> new assistant, bright colour scheme
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/21/96c23c0e-106e-47e0-8f80-90303029e521__assistant_bright.png
> dark colour scheme
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/21/d52643d2-3e0d-494b-bdd7-7beac3f4656c__assistant_dark.png
> alt pressed
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/21/1df94b0b-d763-4aef-9182-ab113fcc3b1a__assistant_hl.png
> assistant, after triggering an action
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/21/c118a296-778c-4cff-86a9-1ff63c2a3e48__assistant_trig.png
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140121/a23e61b6/attachment.html>