Review Request 115194: Reimplemented the SimpleRefactoring class.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115194/#review47925
-----------------------------------------------------------



codegen/refactoring.h
<https://git.reviewboard.kde.org/r/115194/#comment33939>

    const&



codegen/refactoring.h
<https://git.reviewboard.kde.org/r/115194/#comment33940>

    const& + override (and maybe I missed the const& here for the initial interface - sorry please just add it there)



codegen/refactoring.h
<https://git.reviewboard.kde.org/r/115194/#comment33941>

    override



codegen/refactoring.cpp
<https://git.reviewboard.kde.org/r/115194/#comment33942>

    new line for init list


- Milian Wolff


On Jan. 21, 2014, 7:21 p.m., Miquel Sabaté Solà wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115194/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 7:21 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> It now subclasses the BasicRefactoring class from kdevplatform, so we can get rid off most of the code.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7d11097 
>   codegen/CMakeLists.txt e69de29 
>   codegen/refactoring.h PRE-CREATION 
>   codegen/refactoring.cpp PRE-CREATION 
>   codegen/simplerefactoring.h 807b570 
>   codegen/simplerefactoring.cpp 14386d2 
>   pythonlanguagesupport.h 1eaa395 
>   pythonlanguagesupport.cpp 3a76df9 
> 
> Diff: https://git.reviewboard.kde.org/r/115194/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Miquel Sabaté Solà
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140121/4ededcfb/attachment.html>