Review Request 115187: Added the BasicRefactoring class for renaming declarations and uses.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115187/#review47916
-----------------------------------------------------------



language/codegen/basicrefactoring.h
<https://git.reviewboard.kde.org/r/115187/#comment33933>

    just return the vector, its implicitly shared and thus cheap - and NRVO or similar optimizes that further. so remove the const& here


- Milian Wolff


On Jan. 21, 2014, 6:07 p.m., Miquel Sabaté Solà wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115187/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 6:07 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> I've added the BasicRefactoring and the BasicRefactoringCollector classes. These classes provide a base implementation for renaming declarations and uses.
> 
> 
> Diffs
> -----
> 
>   language/CMakeLists.txt 72ab78e 
>   language/codegen/basicrefactoring.h PRE-CREATION 
>   language/codegen/basicrefactoring.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115187/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> 
> Thanks,
> 
> Miquel Sabaté Solà
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140121/f1202ab9/attachment.html>