Review Request 115187: Added the BasicRefactoring class for renaming declarations and uses.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115187/#review47911
-----------------------------------------------------------



language/codegen/basicrefactoring.h
<https://git.reviewboard.kde.org/r/115187/#comment33919>

    please pimpl this class and put this into a getter



language/codegen/basicrefactoring.h
<https://git.reviewboard.kde.org/r/115187/#comment33920>

    void processUses(...) override;



language/codegen/basicrefactoring.h
<https://git.reviewboard.kde.org/r/115187/#comment33921>

    call it fillContextMenu



language/codegen/basicrefactoring.h
<https://git.reviewboard.kde.org/r/115187/#comment33927>

    const& the strings



language/codegen/basicrefactoring.h
<https://git.reviewboard.kde.org/r/115187/#comment33923>

    const&



language/codegen/basicrefactoring.cpp
<https://git.reviewboard.kde.org/r/115187/#comment33925>

    put the init list on a new line:
    
    Foo::Foo()
      : Bar()
    {
    }



language/codegen/basicrefactoring.cpp
<https://git.reviewboard.kde.org/r/115187/#comment33924>

    what needs to be done here? add a comment or do it directly



language/codegen/basicrefactoring.cpp
<https://git.reviewboard.kde.org/r/115187/#comment33926>

    move after the following conditional



language/codegen/basicrefactoring.cpp
<https://git.reviewboard.kde.org/r/115187/#comment33929>

    see below - requires duchain lock or api dox telling that it must be locked already



language/codegen/basicrefactoring.cpp
<https://git.reviewboard.kde.org/r/115187/#comment33928>

    here you need to hold a lock - do you expect that to exist when calling this function? if so - add it to the api dox please



language/codegen/basicrefactoring.cpp
<https://git.reviewboard.kde.org/r/115187/#comment33930>

    I'd prefer if you'd use a .ui file created in designer for this


- Milian Wolff


On Jan. 21, 2014, 5:07 p.m., Miquel Sabaté Solà wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115187/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 5:07 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> I've added the BasicRefactoring and the BasicRefactoringCollector classes. These classes provide a base implementation for renaming declarations and uses.
> 
> 
> Diffs
> -----
> 
>   language/CMakeLists.txt 72ab78e 
>   language/codegen/basicrefactoring.h PRE-CREATION 
>   language/codegen/basicrefactoring.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115187/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> 
> Thanks,
> 
> Miquel Sabaté Solà
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140121/c4e293fb/attachment-0001.html>