Review Request 115158: Fix support for PHP namespaces

Milian Wolff mail at milianw.de
Mon Jan 20 18:27:28 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115158/#review47837
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Jan. 20, 2014, 6:13 p.m., Heinz Wiesinger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115158/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2014, 6:13 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 255537
>     http://bugs.kde.org/show_bug.cgi?id=255537
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> Fix support for PHP namespaces.
> 
> Make sure use Declarations actually find their original declarations and implement lookup for definitions within the same namespace but in a different file.
> Also handle name conflicts.
> 
> I still expect there to be some corner cases that are not supported correctly yet, but this should provide a big improvement already :)
> 
> 
> Diffs
> -----
> 
>   duchain/builders/declarationbuilder.cpp fdbaa276b943787873f6693166a4af66a57b871b 
>   duchain/helper.h ab95549e1062a4311fdb641e96b76043b7f927a7 
>   duchain/helper.cpp 5e01103beb54921817f3667cf6195955c9351f57 
>   duchain/tests/expressionparser.h 2668dad2f59f904b4908e4c24292a284e7da566e 
>   duchain/tests/expressionparser.cpp 579727a980bb699d27d59e7ec8b37bcea9dcc698 
>   duchain/tests/uses.cpp bc9f0b2a64073ff0b95220e8d6d2984c1f2c44bc 
> 
> Diff: https://git.reviewboard.kde.org/r/115158/diff/
> 
> 
> Testing
> -------
> 
> Unit tests, parsing test projects
> 
> 
> Thanks,
> 
> Heinz Wiesinger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140120/8edee832/attachment-0001.html>


More information about the KDevelop-devel mailing list