Review Request 115152: Create the context menu only if the current file requires C/C++

[Miquel Sabaté Solà]

> On Jan. 20, 2014, 2:59 p.m., Aleix Pol Gonzalez wrote:
> > So each plugin will have this if? Or we'll have c++'s and rest of languages'?

Yes. The idea is that each plugin will have this. I've already pushed this in kdev-python. This way when you want to rename for example a variable in C++, only the C++ plugin will provide the context menu and other language plugins won't add their version.


- Miquel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115152/#review47787
-----------------------------------------------------------


On Jan. 20, 2014, 2:40 p.m., Miquel Sabaté Solà wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115152/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2014, 2:40 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Don't add the context menu from the C++ language plugin if the current file is not a C/C++ file. This way some actions like the "rename" action won't clash with other language plugins.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cpplanguagesupport.cpp e17ee53 
> 
> Diff: https://git.reviewboard.kde.org/r/115152/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> 
> Thanks,
> 
> Miquel Sabaté Solà
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140120/2de70c5d/attachment.html>