Review Request 113815: Patch for Bug 221792 - integrate folder browser in "Setup Custom Include Paths"

[Meenakshi Khorana]

> On Nov. 14, 2013, 4:03 p.m., Kevin Funk wrote:
> > languages/cpp/codegen/unresolvedincludeassistant.cpp, line 84
> > <https://git.reviewboard.kde.org/r/113815/diff/1/?file=212620#file212620line84>
> >
> >     You won't need the signal mapper in case you move the code to the correct location

Moved the logic to newly created class.


> On Nov. 14, 2013, 4:03 p.m., Kevin Funk wrote:
> > languages/cpp/codegen/unresolvedincludeassistant.cpp, line 38
> > <https://git.reviewboard.kde.org/r/113815/diff/1/?file=212620#file212620line38>
> >
> >     That is the wrong location for this code snippet. It should be in the yet-to-be-created CustomIncludePathsWidget class.

Created a new class CustomIncPath for same.


- Meenakshi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113815/#review43678
-----------------------------------------------------------


On Jan. 17, 2014, 7:43 a.m., Meenakshi Khorana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113815/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 7:43 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Patch for Bug 221792 - integrate folder browser in "Setup Custom Include Paths" 
> 
> Integrated a folder browser to add custom include paths. User can add custom include paths on a button click and can view the added paths in plain text edit box.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/CMakeLists.txt 66030be 
>   languages/cpp/codegen/customincpath.h PRE-CREATION 
>   languages/cpp/codegen/customincpath.cpp PRE-CREATION 
>   languages/cpp/codegen/ui/custom_include_paths.ui 1a7c1ed 
>   languages/cpp/codegen/unresolvedincludeassistant.cpp 93a72d3 
>   languages/cpp/tests/CMakeLists.txt 9ce3c7b 
> 
> Diff: https://git.reviewboard.kde.org/r/113815/diff/
> 
> 
> Testing
> -------
> 
> Compiled and Tested successfully on local machine.
> 
> 
> File Attachments
> ----------------
> 
> Added open file dialog to custom include path
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/34ab7f7c-7aca-4c16-ab3f-add513c22f56__folder_browser_1.jpg
> Folder browser for selecting include paths
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/29a48901-93ee-40e7-9455-94acb648025e__folder_browser_2.jpg
> Added include paths will be visible to user in text edit
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/bf9fb89b-8e6e-49f8-b2b5-d865ded209b7__folder_browser_3.jpg
> 
> 
> Thanks,
> 
> Meenakshi Khorana
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140117/9a5c9875/attachment-0001.html>