Review Request 113787: Build uses for static strings that reference class name

[Niko Sams]

> On Jan. 14, 2014, 10:47 a.m., Milian Wolff wrote:
> > duchain/expressionvisitor.cpp, line 477
> > <https://git.reviewboard.kde.org/r/113787/diff/1/?file=212410#file212410line477>
> >
> >     do you think this is a good idea? That will mean any file which has some string in it will be reparsed - no?

Yes, but only for strings matching ^[A-Za-z0-9_]+$, though that can be admittedly many.

But I don't see any other alternative that would allow implementing this.


- Niko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113787/#review47362
-----------------------------------------------------------


On Nov. 10, 2013, 4:36 p.m., Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113787/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2013, 4:36 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> In scripting languages class names are often passed around as strings. This patch will build uses for such a string if a class declaration exists.
> 
> Eclipse also does this and it's quite useful to work with.
> 
> 
> Diffs
> -----
> 
>   duchain/expressionvisitor.h b3f954d 
>   duchain/expressionvisitor.cpp cfb256a 
>   duchain/tests/uses.h 4cd0c11 
>   duchain/tests/uses.cpp 95e8d99 
> 
> Diff: https://git.reviewboard.kde.org/r/113787/diff/
> 
> 
> Testing
> -------
> 
> unit tests still pass
> 
> 
> Thanks,
> 
> Niko Sams
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140114/8a8c64e3/attachment-0001.html>