Review Request 115014: Make it possible to click on cmake-automoc error

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115014/#review47377
-----------------------------------------------------------


By the way, the filteringstrateytest needs a major overhaul. Not having the test input inline in the test file is very confusing (cf. testlinebuilderfunctions.h)

Other functions, such as FilteringStrategyTest::testCompilerFilterstrategy don't really check if we've been able to parse the url (and line/col) information. There's FilteringStrategyTest::testExtractionOfLineAndCulmn, which handles that, but only for a subset of the possible cases.

- Kevin Funk


On Jan. 14, 2014, 4:04 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115014/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 4:04 p.m.)
> 
> 
> Review request for KDevelop and Morten Volden.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Make it possible to click on cmake-automoc error
> 
> There's a change needed in outputfilteringstrategies to be able to click
> on error items only containing an url (no line information).
> 
> Morten, any reason you try to enforce having a line number?
> 
> It's still useful, even if we just have the url, imo.
> 
> 
> Diffs
> -----
> 
>   outputview/outputfilteringstrategies.cpp 0dcabd8614dfc160fad612a077150ec297eb3735 
>   outputview/tests/filteringstrategytest.cpp 1177c9aaa32361de5164404639e8d855e53019e3 
> 
> Diff: https://git.reviewboard.kde.org/r/115014/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140114/e4e6a42f/attachment.html>