Review Request 113119: Replace libgraph with libcgraph to be compatible with GraphViz 2.30+

Aleix Pol Gonzalez aleixpol at kde.org
Sat Jan 11 14:44:59 UTC 2014



> On Dec. 28, 2013, 9:21 p.m., Kevin Funk wrote:
> > @Sandro, did you manage to commit this?
> 
> Sandro Andrade wrote:
>     Hi Kevin, sorry for the late reply. Unfortunately I couldn't make this yet, I'm only a month away for delivering my phd thesis and unable to handle this right now. If you can keep this opened until mid-February I'll be available to fix this at that time. Or we close it and reopen later. What do you think ?

Closing and reopening back again doesn't make sense. We can wait, or maybe somebody else can look at it? It has the shipit anyway.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113119/#review46324
-----------------------------------------------------------


On Oct. 5, 2013, 11:46 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113119/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2013, 11:46 p.m.)
> 
> 
> Review request for KDevelop and Sandro Andrade.
> 
> 
> Repository: kdev-control-flow-graph
> 
> 
> Description
> -------
> 
> libgraph is deprecated in GraphViz 2.30 and above. It's replaced with libcgraph. Fedora 19 ships with GraphViz 2.30.1 and thus doesn't include libgraph so it wasn't possible to compile. Luckily there was required only very little changes.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0904ba858da16c58ca637947ba7e698ddaf341bf 
>   cmake/modules/FindGraphViz.cmake c542b05a06e90068ff8a2812c611f6bce2288913 
>   dotcontrolflowgraph.cpp 7d803a5e2992fbb9def3f7f09a50599fb7c15772 
> 
> Diff: https://git.reviewboard.kde.org/r/113119/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140111/800f9b99/attachment.html>


More information about the KDevelop-devel mailing list