Review Request 114775: Don't try to create a new file if we're not in the "code mode".

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114775/#review46624
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Jan. 1, 2014, 12:46 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114775/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2014, 12:46 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
>   Right now if we stop in code without debug symbols installed we'll end up in creating a new file (well actually we were, this patch 7bb3e70e51d3c790efeb8ec1020f96bdc70a78ab by Kevin Funk partially fixes it. Still e.g. double clicking on a breakpoint without existing location would create a new file.)
>   So this patch prevents creating of new files by checking if we're in the "code mode". I think it makes sense, because I see no real reason why it'd be useful to create a new file in the debug or the review mode? There is the edit mode for code editing after all. 
> 
>   Instead we emit new showStepInDisassemble signal, indicating that there is no debug symbols/file available. 
>   Also there is no need in preselecting a frame stack with debug symbols anymore (as DisassembleWidget takes care of it), so I've removed this hack too.
> 
> 
> Diffs
> -----
> 
>   debugger/framestack/framestackmodel.cpp 0f79538 
>   debugger/interfaces/idebugsession.h 33e456d 
>   debugger/interfaces/idebugsession.cpp e14f808 
>   shell/debugcontroller.cpp a9f1eec 
>   shell/documentcontroller.cpp ad0a58f 
> 
> Diff: https://git.reviewboard.kde.org/r/114775/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140102/fed6873b/attachment.html>