Review Request 115992: PCH support in kdev-clang

[Olivier Jean de Gaalon]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115992/
-----------------------------------------------------------

(Updated Feb. 28, 2014, 7:12 p.m.)


Review request for KDevelop and Milian Wolff.


Changes
-------

This should be production ready, no known issues. Review away.


Repository: kdev-clang


Description
-------

This is a little dirty, but I probably won't be able to work on it any more this week, so at least I can throw it up for feedback. Give special attention to parselock, because I didn't take the time to see how it's supposed to be used.


Diffs (updated)
-----

  clangparsejob.h b12e9df 
  clangparsejob.cpp 86588ce 
  duchain/CMakeLists.txt 7ab2e8a 
  duchain/clanghelpers.h PRE-CREATION 
  duchain/clanghelpers.cpp PRE-CREATION 
  duchain/clangpch.h PRE-CREATION 
  duchain/clangpch.cpp PRE-CREATION 
  duchain/clangtypes.h b4baba7 
  duchain/clangtypes.cpp f8eb8b8 
  duchain/includedfilecontexts.h 4bdd6ca 
  duchain/includedfilecontexts.cpp 90d800c 
  duchain/parsesession.h e557884 
  duchain/parsesession.cpp 265e099 
  duchain/tuduchain.h e0e8d44 

Diff: https://git.reviewboard.kde.org/r/115992/diff/


Testing
-------

It works, including with epic-size projects. It still doesn't resume properly for some reason (clang will complain about invalid PCH, create an invalid tu, and the pch contexts will be nuked). I haven't had time to look into that, just have to remove the pch and rebuild for now.


Thanks,

Olivier Jean de Gaalon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140228/1835326e/attachment.html>