Review Request 116053: Add ability to automatically include headers

[Sergey Kalinichev]

> On Feb. 26, 2014, 10:48 p.m., Milian Wolff wrote:
> > languages/cpp/preprocessjob.cpp, line 240
> > <https://git.reviewboard.kde.org/r/116053/diff/1/?file=246053#file246053line240>
> >
> >     this looks wrong, what is this about?

I can't figure out what you are refering to :(
1. The comment? Should I remove/rephrase it then?
2. The "auto include feature" itself? See e.g. http://bugs.kde.org/show_bug.cgi?id=315705, and also clang/gcc -include command line option.
3. The way I implemented it? What is wrong with it then?
4. Something else?


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116053/#review50973
-----------------------------------------------------------


On Feb. 25, 2014, 10:33 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116053/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 10:33 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 315705
>     http://bugs.kde.org/show_bug.cgi?id=315705
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Add ability to automatically include headers
> 
> 
> Diffs
> -----
> 
>   languages/cpp/preprocessjob.cpp f0343f8 
> 
> Diff: https://git.reviewboard.kde.org/r/116053/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140227/a6b1eedc/attachment.html>