Review Request 115987: Memory leak in PythonCodeCompletionContext::completionItems

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115987/#review50690
-----------------------------------------------------------

Ship it!


I think I already cleaned this one up in the Python 3 branch, but yep -- please push ;)

- Sven Brauch


On Feb. 24, 2014, 5:49 a.m., Alexandr Zamaraev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115987/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 5:49 a.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> Memory leak in PythonCodeCompletionContext::completionItems
> Local variable AstBuilder* builder allocated and newer deleted.
> 
> Also drop unnecessary QSharedPointer in visitorForString.
> 
> Path for branch 1.6
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp e710fd0 
> 
> Diff: https://git.reviewboard.kde.org/r/115987/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandr Zamaraev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140224/cb61ab52/attachment.html>