Review Request 115992: PCH support in kdev-clang

Olivier Jean de Gaalon olivier.jg at gmail.com
Mon Feb 24 09:56:08 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115992/
-----------------------------------------------------------

Review request for KDevelop and Milian Wolff.


Repository: kdev-clang


Description
-------

This is a little dirty, but I probably won't be able to work on it any more this week, so at least I can throw it up for feedback. Give special attention to parselock, because I didn't take the time to see how it's supposed to be used.


Diffs
-----

  clangparsejob.h b12e9df 
  clangparsejob.cpp 86588ce 
  duchain/parsesession.h e557884 
  duchain/parsesession.cpp 265e099 

Diff: https://git.reviewboard.kde.org/r/115992/diff/


Testing
-------

It works, including with epic-size projects. It still doesn't resume properly for some reason (clang will complain about invalid PCH, create an invalid tu, and the pch contexts will be nuked). I haven't had time to look into that, just have to remove the pch and rebuild for now.


Thanks,

Olivier Jean de Gaalon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140224/de281b2f/attachment.html>


More information about the KDevelop-devel mailing list