Review Request 115860: Fix CMake variable names

[David Stevens]

> On Feb. 18, 2014, 7:18 a.m., Kevin Funk wrote:
> > CMakeLists.txt, line 19
> > <https://git.reviewboard.kde.org/r/115860/diff/1/?file=244706#file244706line19>
> >
> >     Why CLANG_LIBS? That's the list of all Clang *libraries*, you don't want to pass that to link_directories.
> >     
> >     This should be LLVM_LIBRARY_DIR.
> 
> Andreas Pakulat wrote:
>     link_directories is not a good idea anyway, its deprecated by cmake upstream since years and can easily cause linking issues. No idea which variables are exported but target_link_libraries should be used with variables for all libraries that need to be linked against.
> 
> Kevin Funk wrote:
>     Makes sense. CLANG_CLANG_LIB and friends all consist of absolute paths, so CMake should figure this out on its own when using target_link_libraries(.
>     
>     @David: Please drop the line altogether. Does it still work for you then?

Yeah, it works. Makes sense since LLVM_LIBRARY_DIRS was empty before.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115860/#review50124
-----------------------------------------------------------


On Feb. 18, 2014, 9:45 p.m., David Stevens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115860/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 9:45 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Some variables defined in FindClang.cmake use the wrong names in CMakeLists.txt.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b8451f3 
> 
> Diff: https://git.reviewboard.kde.org/r/115860/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Stevens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140220/01b95001/attachment.html>