Review Request 115860: Fix CMake variable names

Kevin Funk kfunk at kde.org
Tue Feb 18 07:18:12 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115860/#review50124
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/115860/#comment35236>

    Why CLANG_LIBS? That's the list of all Clang *libraries*, you don't want to pass that to link_directories.
    
    This should be LLVM_LIBRARY_DIR.


- Kevin Funk


On Feb. 18, 2014, 1:21 a.m., David Stevens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115860/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 1:21 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Some variables defined in FindClang.cmake use the wrong names in CMakeLists.txt.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b8451f3 
> 
> Diff: https://git.reviewboard.kde.org/r/115860/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Stevens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140218/78494554/attachment.html>


More information about the KDevelop-devel mailing list